Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2201.3.x] Fix getting redeclared symbol error when the same symbol is used in two if-else blocks #39358

Closed
wants to merge 2 commits into from
Closed

[2201.3.x] Fix getting redeclared symbol error when the same symbol is used in two if-else blocks #39358

wants to merge 2 commits into from

Conversation

lasinicl
Copy link
Contributor

Purpose

$title

Fixes #39065

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@lasinicl lasinicl added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label Jan 25, 2023
@codecov
Copy link

codecov bot commented Jan 25, 2023 •
edited
Loading

Codecov Report

Patch coverage: 93.54% and project coverage change: +0.28 🎉

Comparison is base (cc62bf7) 76.31% compared to head (4d48dbf) 76.60%.

Additional details and impacted files 
@@              Coverage Diff               @@
##             2201.3.x   #39358      +/-   ##
==============================================
+ Coverage       76.31%   76.60%   +0.28%     
- Complexity      53149    55061    +1912     
==============================================
  Files            3383     3395      +12     
  Lines          199858   206796    +6938     
  Branches        26027    28270    +2243     
==============================================
+ Hits           152514   158408    +5894     
- Misses          38618    39557     +939     
- Partials         8726     8831     +105
Impacted Files Coverage Δ
...nalang/testerina/core/MockAnnotationProcessor.java 85.79% <93.33%> (+8.87%) ⬆️
.../compiler/semantics/analyzer/SemanticAnalyzer.java 91.20% <100.00%> (-0.01%) ⬇️

... and 96 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Feb 14, 2023
@lasinicl lasinicl removed the Stale label Feb 15, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Mar 3, 2023
@lasinicl lasinicl removed the Stale label Mar 4, 2023
@github-actions
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Mar 24, 2023
@lasinicl lasinicl removed the Stale label Mar 24, 2023
gimantha
gimantha previously approved these changes Mar 25, 2023
View reviewed changes
Copy link
Contributor

@gimantha gimantha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Apr 9, 2023

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Apr 9, 2023
@github-actions
Copy link

Closed PR due to inactivity for more than 18 days.

@github-actions github-actions bot closed this Apr 12, 2023
@ushirask ushirask reopened this Jun 12, 2023
@ushirask ushirask changed the base branch from 2201.3.x to master June 12, 2023 06:26
@ushirask ushirask dismissed gimantha’s stale review June 12, 2023 06:26

The base branch was changed.

@ushirask ushirask changed the base branch from master to 2201.3.x June 12, 2023 06:29
@ushirask ushirask mentioned this pull request Jun 14, 2023
Merged
13 tasks
@github-actions
Copy link

Closed PR due to inactivity for more than 18 days.

@github-actions github-actions bot closed this Jun 15, 2023
@hasithaa hasithaa removed the Stale label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gimantha gimantha gimantha left review comments

@sameerajayasoma sameerajayasoma Awaiting requested review from sameerajayasoma sameerajayasoma is a code owner

@hasithaa hasithaa Awaiting requested review from hasithaa hasithaa is a code owner

@MaryamZi MaryamZi Awaiting requested review from MaryamZi

@chiranSachintha chiranSachintha Awaiting requested review from chiranSachintha

@anupama-pathirage anupama-pathirage Awaiting requested review from anupama-pathirage

@warunalakshitha warunalakshitha Awaiting requested review from warunalakshitha

@mohanvive mohanvive Awaiting requested review from mohanvive

@manuranga manuranga Awaiting requested review from manuranga

@hevayo hevayo Awaiting requested review from hevayo

@IMS94 IMS94 Awaiting requested review from IMS94

Assignees
No one assigned
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lasinicl @gimantha @chiranSachintha @hasithaa @ushirask